Skip to content

refactor(ui5-li-notification): change close event to non-bubbling #11905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 30, 2025
Merged

refactor(ui5-li-notification): change close event to non-bubbling #11905

merged 6 commits into from
Jul 30, 2025
+150 −3

Conversation

LidiyaGeorgieva
Copy link
Contributor

fixes: #11756

@LidiyaGeorgieva LidiyaGeorgieva requested review from pskelin, ilhan007 and a team July 11, 2025 13:36
TeodorTaushanov
TeodorTaushanov requested changes Jul 23, 2025
View reviewed changes
Copy link
Member

@TeodorTaushanov TeodorTaushanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close event is the ui5-list shouldn't bubble as well.

@TeodorTaushanov TeodorTaushanov self-requested a review July 29, 2025 08:12
@LidiyaGeorgieva LidiyaGeorgieva merged commit fdccbe3 into main Jul 30, 2025
43 of 52 checks passed
@LidiyaGeorgieva LidiyaGeorgieva deleted the NotificationsCLoseEvent branch July 30, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeodorTaushanov TeodorTaushanov TeodorTaushanov approved these changes

@pskelin pskelin Awaiting requested review from pskelin

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NotificationList: clicking "close" button fires bubbling "close" event
2 participants
@LidiyaGeorgieva @TeodorTaushanov