fix(ui5-color-picker): ensure RGB and HSL values are within limits #11915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinzzx
changed the title
GDamyanov
requested changes
Jul 15, 2025
GDamyanov
approved these changes
Jul 15, 2025
didip1000
reviewed
Jul 16, 2025
didip1000
reviewed
Jul 21, 2025
tsanislavgatev
requested changes
Jul 28, 2025
tsanislavgatev
approved these changes
Jul 30, 2025
|
🎉 This PR is included in version v2.13.0 🎉 The release is available on v2.13.0 Your semantic-release bot 📦🚀 |
nnaydenow
pushed a commit
that referenced
this pull request
Aug 18, 2025
…11915) Previously if an user was about to type a RGB or HSL value in the input fields, that were out of boundaries (from 0 to 255 for all RGB fields, 0 to 360 for Hue, 0 to 100(%) for Saturation and Light in HSL), the input fields became disabled, which led to bad UX. With this change we now 'normalise' the values that are out of the bounds (mentioned above) to the closest one. For RGB: values above 255 –> e.g 275 are normalised to 255; values below 0 –> e.g -20 are normalised to 0; For HSL: Hue: values above 360 –> e.g 375 are normalised to 360; values below 0 –> e.g -20 are normlised to 0; Saturation and Light: values above 100 –> e.g. 120 are normalised to 100; values below 0 –> e.g. -20 are normalised
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if an user was about to type a RGB or HSL value in the input fields, that were out of boundaries (from 0 to 255 for all RGB fields, 0 to 360 for Hue, 0 to 100(%) for Saturation and Light in HSL), the input fields became disabled, which led to bad UX.
With this change we now 'normalise' the values that are out of the bounds (mentioned above) to the closest one.
For RGB:
For HSL:
Hue:
Saturation and Light:
Before
After