fix(ui5-responsive-popover): fix open/close state, when initially open #12236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the ResponsivePopover host element could stay visually open even when not intended to be visible on non-mobile devices. The fix refactors the popup opening logic to properly handle different device types.
- Extracts popup opening logic into a reusable
onEnterDOMOpen()method in the base Popup class - Overrides the method in ResponsivePopover to handle phone vs non-phone device differences
- Adds test coverage for the dialog visibility behavior on mobile devices
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/main/src/Popup.ts | Refactors onEnterDOM() to extract popup opening logic into separate onEnterDOMOpen() method |
| packages/main/src/ResponsivePopover.ts | Overrides onEnterDOMOpen() to only show popover on non-phone devices when open |
| packages/main/cypress/specs/ResponsivePopover.mobile.cy.tsx | Changes test setup from before() to beforeEach() and adds test for dialog visibility |
TeodorTaushanov
requested changes
Sep 2, 2025
duygu-rmdn
changed the title
TeodorTaushanov
approved these changes
Sep 3, 2025
|
🎉 This PR is included in version v2.14.0-rc.7 🎉 The release is available on v2.14.0-rc.7 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #12225