Skip to content

fix(ui5-responsive-popover): fix open/close state, when initially open #12236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

fix(ui5-responsive-popover): fix open/close state, when initially open #12236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e08a4f9
fix(ui5-responsive-popover): prevent host element from staying open o…
duygu-rmdn Sep 1, 2025
928312f
fix(ui5-responsive-popover): fix background of initially opened dialog
duygu-rmdn Sep 2, 2025
fb52a17
fix(ui5-responsive-popover): rename the new method
duygu-rmdn Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/main/cypress/specs/ResponsivePopover.mobile.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Input from "../../src/Input.js";
import Label from "../../src/Label.js";

describe("ResponsivePopover mobile general interaction", () => {
before(() => {
beforeEach(() => {
cy.ui5SimulateDevice();
});

Expand All @@ -21,6 +21,18 @@ describe("ResponsivePopover mobile general interaction", () => {
.find("[ui5-dialog]")
.should("be.visible");
});

it("tests showing of the dialog on phone", () => {
cy.mount(<ResponsivePopover open={true} />);

cy.get("[ui5-responsive-popover]")
.shadow()
.find("[ui5-dialog]")
.should("be.visible");

cy.get("[ui5-responsive-popover]")
.should("not.be.visible");
});
});

describe("Accessibility", () => {
Expand Down
10 changes: 7 additions & 3 deletions packages/main/src/Popup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 +290,17 @@ abstract class Popup extends UI5Element {

this.tabIndex = -1;

this.handleOpenOnEnterDOM();

this.setAttribute("data-sap-ui-fastnavgroup-container", "true");
registerUI5Element(this, this._updateAssociatedLabelsTexts.bind(this));
}

handleOpenOnEnterDOM() {
if (this.open) {
this.showPopover();
this.openPopup();
}

this.setAttribute("data-sap-ui-fastnavgroup-container", "true");
registerUI5Element(this, this._updateAssociatedLabelsTexts.bind(this));
}

onExitDOM() {
Expand Down
7 changes: 7 additions & 0 deletions packages/main/src/ResponsivePopover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ class ResponsivePopover extends Popover {
}
}

handleOpenOnEnterDOM() {
if (this.open && !isPhone()) {
this.showPopover();
this.openPopup();
}
}

_dialogCloseButtonClick() {
this.closePopup();
}
Expand Down
Loading