Skip to content

#13879 - Fixed external message case comments#13881

Merged
raulbob merged 1 commit intodevelopmentfrom
bugfix-13879-external_message_processing_fails_value_too_long
Mar 13, 2026
Merged

#13879 - Fixed external message case comments#13881
raulbob merged 1 commit intodevelopmentfrom
bugfix-13879-external_message_processing_fails_value_too_long

Conversation

@raulbob
Copy link
Contributor

@raulbob raulbob commented Mar 13, 2026

Fixes #13879

Summary by CodeRabbit

  • New Features

    • Enhanced case data processing to capture additional case details from comments.
    • Extended system with support for environmental monitoring, surveys, and adverse event tracking.
    • Introduced document management capabilities and self-report functionality.
    • Implemented comprehensive role-based access control with granular permission management.
    • Added data versioning and audit trail capabilities across core entities.
  • Chores

    • Database schema updates to support expanded data tracking and compliance requirements.

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 50084f25-bf13-42a8-a3d5-5446134593dc

📥 Commits

Reviewing files that changed from the base of the PR and between 870fe72 and b897f3f.

📒 Files selected for processing (2)
  • sormas-api/src/main/java/de/symeda/sormas/api/externalmessage/processing/AbstractProcessingFlow.java
  • sormas-backend/src/main/resources/sql/sormas_schema.sql

📝 Walkthrough

Walkthrough

These changes extend the SORMAS database schema with new entities for environmental management, surveys, adverse events following immunization, and self-reporting, while also mapping external message case comments to case additional details to support larger text values.

Changes

Cohort / File(s) Summary
External Message Case Comment Mapping
sormas-api/src/main/java/de/symeda/sormas/api/externalmessage/processing/AbstractProcessingFlow.java
Populates CaseDataDto.additionalDetails from ExternalMessageDto.caseComments in buildCase method to accommodate larger comment values beyond 255 characters.
Database Schema Extensions
sormas-backend/src/main/resources/sql/sormas_schema.sql
Introduces new tables for environments, surveys, special case access management, adverse events, self-reports, documents, and system configuration with corresponding versioned history tables and triggers. Adds new privilege-based user rights, foreign key constraints, and procedural functions for data migration and management. Expands existing tables with additional columns for disease variants, diagnostics, sampling reasons, and audit tracking.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

Suggested reviewers

  • obinna-h-n
  • KarnaiahPesula

Poem

🐰 A message comes with words so long,
Too many characters, oh dear, what's wrong?
Into additionalDetails we now place,
Those lengthy comments, they find their space.
The schema grows with tables new,
Environments and surveys too! 🌱📋

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR partially addresses issue #13879 in the Java code changes, but the massive schema.sql modifications appear unrelated to the specific case comments field length issue. The schema.sql changes exceed the scope of fixing the case comments field. Clarify whether the schema changes are necessary for this fix or should be separated into a different PR.
Out of Scope Changes check ⚠️ Warning The sormas_schema.sql file contains extensive unrelated changes including new tables, functions, and infrastructure changes that far exceed the scope of fixing case comments field length validation. Remove the sormas_schema.sql changes from this PR or provide clear justification linking these changes to issue #13879. Consider splitting into separate PRs.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the fix for issue #13879 regarding external message case comments processing failure.
Description check ✅ Passed The PR description minimally follows the template by referencing issue #13879, though it lacks detailed explanation of the changes made to fix the problem.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix-13879-external_message_processing_fails_value_too_long
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KarnaiahPesula KarnaiahPesula self-requested a review March 13, 2026 11:02
@sormas-vitagroup
Copy link
Contributor

@raulbob raulbob merged commit 5d15f2c into development Mar 13, 2026
8 of 14 checks passed
@raulbob raulbob deleted the bugfix-13879-external_message_processing_fails_value_too_long branch March 13, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

External message processing fails if the case comments are larger than 255 characters - External Message

3 participants