-
Notifications
You must be signed in to change notification settings - Fork 31
Feat: Update updateApis script to pull APIs based on versions (@W-18557453@)
#241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… step to update the version file it self with the latest available version
e8bfc02 to
076cc3f
Compare
|
@kbode-sf Can you add steps in the PR description on how to run the @felix-schaube can you please test this as well. I asked Duc yesterday and he did not require any other configuration. So it seem to be a local setup issue of Joel. |
joeluong-sfcc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm, yarn updateApis now updates the APIs based on the versions in api-versions.txt and yarn updateApiVersions updates the api-versions.txt to the latest versions available in anypoint exchange correct?
api-versions.txt
Outdated
| shopper-search-oas-v1=1.3.0 | ||
| shopper-seo-oas-v1=1.0.13 | ||
| shopper-stores-oas-v1=1.0.17 | ||
| shopper-payments-oas-v1=1.2.0-master-b70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in future updates we can add better error handling for improper formatting of API name and version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, this was only a draft
updateApis script to pull APIs based on versions (@W-18557453@)
|
For the updateApis PR, are we sure we want the updateApiVersions setting snapshot versions rather than the latest stable version on Anypoint Exchange? |
@joeluong-sfcc thats correct. However as mentioned in a private slack conversation I think updateApiVersions needs "refinement". To support different modes like only pulling the latest release version and not SNAPSHOTs or limit the update on a list of APIs. (FYI @vcua-mobify ) |
Removed this script and created another branch for it: https://github.com/SalesforceCommerceCloud/commerce-sdk-isomorphic/pulls |
This PR updates the
yarn updateApisscript to pull in APIs based on API versions instead of pulling the latest APIs, as we now have to align our releases with ECOM which have pinned versions each release. This versions are controlled in a file,api-versions.txt.Testing
ANYPOINT_USERNAMEandANYPOINT_PASSWORDenvironment variablesapi-versions.txtwith the following:yarn updateApisand verify that APIs have been updated to that specific version