Fix typos in ComponentTraits.md and returning error code upon creating a struct with a syntax error but no members #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
999pingGG
changed the title
|
Looks good! Can you add a test case (in |
|
After sending this PR, I noticed some more issues related to empty structs even with my fix, and those require further investigation. I mean, you shouldn't be trying to parse and create empty structs, but resiliency is always good. I came across those bugs while writing my LuaJIT bindings and writing my own tests, let's prevent crashes as much as possible. I will investigate the problematic cases and write tests for them later. |
|
Sounds good! Can you split off the changes to ComponentTraits.md into a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed
ecs_meta_from_desc()prints an error when passed the description{about missing the closing brace, but still returns 0 (success). This commit fixes that. Let me know about any issues with this! I'm not sure about how to add test cases for this tho.