Skip to content

Conversation

scop
Copy link
Contributor

@scop scop commented Jul 25, 2025

No description provided.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

Thanks! I'm a little hesitant to change the primary URLs in a way that substitutes main and master for a commit or tag because it would mean they would no longer automatically stay up to date, which is a behavior that I think some authors intentionally depend on. But those cases, I'll definitely be able to accept adding those new URLs that include a tag in the versions field. The rest of the changes look great.

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR is stale and will be closed in 7 days(auto-generated by stale action) label Sep 25, 2025
@hyperupcall
Copy link
Member

I looked through some of the links and of the ones I checked, they all 404'd. This is an improvement! I take back what I said before

@hyperupcall hyperupcall removed the Stale PR is stale and will be closed in 7 days(auto-generated by stale action) label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants