Skip to content

feat: integrate callback saving into integrator init and finalize #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2025
Merged

feat: integrate callback saving into integrator init and finalize #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7b8b21
feat: integrate callback saving into integrator init and finalize
AayushSabharwal Aug 25, 2025
dd09f9e
build: bump SciMLBase, DiffEqBase, OrdinaryDiffEqCore, StochasticDiff…
AayushSabharwal Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Adapt = "4"
Aqua = "0.8"
ArrayInterface = "7.15"
DataStructures = "0.18, 0.19"
DiffEqBase = "6.181"
DiffEqBase = "6.186"
DiffEqCallbacks = "4.7"
DocStringExtensions = "0.9"
ExplicitImports = "1"
Expand All @@ -47,18 +47,19 @@ KernelAbstractions = "0.9"
LinearAlgebra = "1"
LinearSolve = "3"
OrdinaryDiffEq = "6"
OrdinaryDiffEqCore = "1.32.0"
Pkg = "1"
PoissonRandom = "0.4"
Random = "1"
RecursiveArrayTools = "3.32"
Reexport = "1.2"
SafeTestsets = "0.1"
SciMLBase = "2.95"
SciMLBase = "2.115"
Setfield = "1.1"
StableRNGs = "1"
StaticArrays = "1.9"
Statistics = "1"
StochasticDiffEq = "6"
StochasticDiffEq = "6.82"
SymbolicIndexingInterface = "0.3.35"
Test = "1"
UnPack = "1.0.2"
Expand All @@ -72,6 +73,7 @@ FastBroadcast = "7034ab61-46d4-4ed7-9d0f-46aef9175898"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
LinearSolve = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
OrdinaryDiffEqCore = "bbf590c4-e513-4bbe-9b18-05decba2e5d8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed given we load OrdinaryDiffeq?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure compat bounds don't work if the package isn't a dependency somewhere. So I added ODECore to extras to be able to add a compat.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we only want to do direct dependencies, anything that isn't direct should get changed. We should ExplicitImports.jl test this package, but that can come later.

Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
Expand Down
6 changes: 6 additions & 0 deletions src/SSA_stepper.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,9 @@ function DiffEqBase.solve!(integrator::SSAIntegrator)
end

DiffEqBase.finalize!(integrator.opts.callback, integrator.u, integrator.t, integrator)
if integrator.save_end
SciMLBase.save_final_discretes!(integrator, integrator.opts.callback)
end

if integrator.sol.retcode === ReturnCode.Default
integrator.sol = DiffEqBase.solution_new_retcode(integrator.sol, ReturnCode.Success)
Expand Down Expand Up @@ -246,6 +249,9 @@ function DiffEqBase.__init(jump_prob::JumpProblem,
save_end, cur_saveat, opts, _tstops, 1, false, true, alias_tstops, false)
cb.initialize(cb, integrator.u, prob.tspan[1], integrator)
DiffEqBase.initialize!(opts.callback, integrator.u, prob.tspan[1], integrator)
if save_start
SciMLBase.save_discretes_if_enabled!(integrator, opts.callback; skip_duplicates = true)
end
integrator
end

Expand Down
Loading