Fix integer bounds error in OptimizationMOI #947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #528 - This PR adds Float64 conversion for bounds in
MOI.GreaterThan
andMOI.LessThan
constraints to handle integer constraint vectors properly.Problem
When users pass integer vectors for
lb
andub
parameters, OptimizationMOI throws a confusing error:This happens because MOI expects Float64 types for constraints, but the code in
nlp.jl
wasn't converting integer bounds.Solution
Added
Float64()
conversion when creating the constraints:MOI.GreaterThan(evaluator.lb[i])
→MOI.GreaterThan(Float64(evaluator.lb[i]))
MOI.LessThan(evaluator.ub[i])
→MOI.LessThan(Float64(evaluator.ub[i]))
This matches the implementation in
moi.jl
which already had this conversion.Example
Before this fix:
After this fix:
Testing
moi.jl
🤖 Generated with Claude Code