Fix LBFGS iteration counter always showing 0 #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #907 - Added iteration tracking to LBFGS callbacks so that OptimizationState.iter properly increments during optimization. Previously, the iteration counter was always 0 in callbacks because the LBFGS solver wasn't tracking iterations. Now uses a Ref counter that increments with each function evaluation. Changes: - Added iter_count = Ref(0) before _loss function definition - Increment iter_count[] in _loss function - Pass iter_count[] to OptimizationState constructor - Applied fix to both constrained and unconstrained cases 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
| @@ -116,13 +116,15 @@ function SciMLBase.__solve(cache::OptimizationCache{ | |||
| cache.f.cons(cons_tmp, cache.u0) | |||
| ρ = max(1e-6, min(10, 2 * (abs(cache.f(cache.u0, cache.p))) / norm(cons_tmp))) | |||
|
|
|||
| iter_count = Ref(0) | |||
There was a problem hiding this comment.
Why is a simple integer not enough? 😅
There was a problem hiding this comment.
You would need to box it anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #907 - This PR fixes the LBFGS solver's iteration counter which was always showing 0 in callbacks.
Problem
When using callbacks with
Optimization.LBFGS(), theopt_state.itervalue was always 0, making it impossible to track optimization progress. This was inconsistent with other solvers like Adam which properly increment the iteration counter.Example from the issue:
Solution
Added iteration tracking using a
Refcounter that increments with each loss function evaluation:iter_count = Ref(0)before the_lossfunction definitioniter_count[]inside the loss functioniter_count[]to theOptimizationStateconstructorTesting
Tested with the example from the issue:
The iteration counter now properly increments, matching the behavior of other solvers.
🤖 Generated with Claude Code