Migrate OptimizationBase.jl as sublibrary and apply maxsense fix #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR migrates OptimizationBase.jl to become a sublibrary within Optimization.jl, consolidating the optimization ecosystem into a single repository while maintaining all existing functionality. ## Key Changes ### Migration - **OptimizationBase sublibrary**: Copied all source code, extensions, and tests to `lib/OptimizationBase/` - **Dependency integration**: Added OptimizationBase dependencies to main Project.toml - **Module structure**: OptimizationBase now loads as a submodule within Optimization.jl - **Import fixes**: Updated OptimizationDIExt.jl and OptimizationDISparseExt.jl imports ### CI Configuration - **Test matrix**: Added OptimizationBase to CI test groups - **Coverage**: Added OptimizationBase source directory to coverage reporting - **Test runner**: Updated runtests.jl to support OptimizationBase sublibrary testing ### Bug Fix (from OptimizationBase.jl#146) - **MaxSense support**: Added proper `sense` parameter handling in `instantiate_function` - **Objective negation**: Modified objective function to handle MaxSense by negating it - **Cache integration**: Updated OptimizationCache to pass sense parameter ### Issue Migration - **Issues transferred**: All 14 open issues from OptimizationBase.jl moved to Optimization.jl - **Issue numbers**: OptimizationBase.jl issues now available as Optimization.jl#967-981 ## Testing - OptimizationBase sublibrary: 672 tests passing - Main Optimization.jl module: Successfully loads with embedded OptimizationBase - All existing functionality preserved ## Files Changed - `.github/workflows/CI.yml`: Added OptimizationBase to test matrix and coverage - `Project.toml`: Added OptimizationBase dependencies and constraints - `src/Optimization.jl`: Updated to include OptimizationBase as submodule - `test/runtests.jl`: Added OptimizationBase to core test dependencies - `lib/OptimizationBase/`: Complete OptimizationBase source code and tests - `lib/OptimizationBase/src/cache.jl`: Added sense parameter support - `lib/OptimizationBase/src/function.jl`: Applied maxsense fix for objective function 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates OptimizationBase.jl to become a sublibrary within Optimization.jl, consolidating the optimization ecosystem into a single repository while maintaining all existing functionality. Additionally, it applies the maxsense fix from OptimizationBase.jl#146.
Motivation
Key Changes
🏗️ Migration Infrastructure
lib/OptimizationBase/🔧 CI Configuration
🐛 Bug Fix (OptimizationBase.jl#146)
senseparameter toinstantiate_function📋 Issue Migration
AutoSymbolicsandAutoModelingToolkitdifferent backends #967-981Files Changed
Core Migration
lib/OptimizationBase/: Complete OptimizationBase source code and tests (28 files)src/Optimization.jl: Updated to include OptimizationBase as submoduleProject.toml: Added OptimizationBase dependencies and compatibility constraintsCI and Testing
.github/workflows/CI.yml: Added OptimizationBase to test matrix and coveragetest/runtests.jl: Added OptimizationBase to core test dependenciesBug Fix Implementation
lib/OptimizationBase/src/cache.jl: Added sense parameter supportlib/OptimizationBase/src/function.jl: Applied maxsense fix for objective functionTesting Results
✅ OptimizationBase sublibrary: 672 tests passing, 1 error (pre-existing)
✅ Main Optimization.jl: Successfully loads with embedded OptimizationBase
✅ All functionality preserved: No breaking changes to existing API
Breaking Changes
None. This is a purely internal restructuring that maintains all existing public APIs.
Checklist
Related Issues
Closes OptimizationBase.jl#146 (maxsense fix)
Addresses repository consolidation discussed in various SciML planning issues
🤖 Generated with Claude Code