Fix nla allocation situation #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for taking a stab at this, at a first glance it seems to be on point! the |
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 87.33% 87.35% +0.02%
==========================================
Files 13 13
Lines 616 617 +1
==========================================
+ Hits 538 539 +1
Misses 78 78
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #120. Preemptive apologies if the code isn't up to best practices, I just saw the issue lying around and tried to hack together a solution.
I'm on Julia 1.7.3, so there are some tests failing ( #124 ), but the same tests fail before and after, so at least we have that going.
The speedups are most noticeable for the case of many calls with small arrays, with ~1.2-1.4x speedup for 1k x 1k arrays. I don't know what the arrays are supposed to look like, so I just tested out a bunch of sizes.
I'm not really a common Julia package contributor, so I can attempt edits if there's something I've done horrendously wrong in terms of style/best practices.