-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
kubetail: Add version 0.9.0 #6809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Your changes do not pass checks. kubetail
|
Just checking - is this PR mergeable? The most recent version passed validation but the PR still has a "manifest-fix-needed" label. Let me know if I need to change something to merge PR. |
/verify |
Your changes do not pass checks. kubetail
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if you may want to rename downloaded binaries as they referenced in bin
section, otherwise shim creation will fail.
Alternatively you could use .zip artifacts instead (will be unpacked automatically).
@aliesbelik Thanks! That's helpful. |
/verify |
Your changes do not pass checks. kubetail
|
/verify |
Your changes do not pass checks. kubetail
|
/verify |
Your changes do not pass checks. kubetail
|
/verify |
Your changes do not pass checks. kubetail
|
/verify |
Your changes do not pass checks. kubetail
|
/verify |
Your changes do not pass checks. kubetail
|
/verify |
Your changes do not pass checks. kubetail
|
/verify |
Your changes do not pass checks. kubetail
|
/verify |
Your changes do not pass checks. kubetail
|
/verify |
All changes look good. Wait for review from human collaborators. kubetail
|
WalkthroughAdds a new Scoop manifest Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FYI I rebased and squashed the commits |
/verify |
All changes look good. Wait for review from human collaborators. kubetail
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aliesbelik You approved this PR two weeks ago and there are no conflicts with the base branch but it hasn't been merged yet. Is there an issue or something we're missing on our end? |
@amorey I'm not a maintainer of this particular bucket ( |
@aliesbelik No worries, thanks for the update. |
@aliesbelik There's still a "review needed" label on the PR. Could the maintainer be waiting for that to be removed? |
Signed-off-by: Andres Morey <[email protected]>
Co-authored-by: Aliaksandr Belik <[email protected]>
Signed-off-by: Andres Morey <[email protected]>
Signed-off-by: Andres Morey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
bucket/kubetail.json (2)
18-20
: Anchor the checkver regex for precisionAvoid accidental partial matches by anchoring to the tag format.
- "regex": "cli/v([\\d.]+)" + "regex": "^cli\\/v([\\d.]+)$"
4-4
: Optional: point homepage to the GitHub repositoryKeeps metadata consistent with checkver target and the issue reference.
- "homepage": "https://www.kubetail.com", + "homepage": "https://github.com/kubetail-org/kubetail",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/kubetail.json
(1 hunks)
🔇 Additional comments (1)
bucket/kubetail.json (1)
6-16
: Manifest structure LGTM (arch URLs, hashes, bin rename)URLs, per-arch hashes, and bin rename via fragment look correct.
Signed-off-by: Andres Morey <[email protected]>
Signed-off-by: Andres Morey <[email protected]>
Fixes #7182
Kubetail is a real-time logging dashboard for Kubernetes. This PR adds the "kubetail" CLI tool as a package.
<manifest-name[@version]|chore>: <general summary of the pull request>
Summary by CodeRabbit