[SCR-584] Send API key via Authorization header - #26
Open
sahilsunny wants to merge 2 commits into
Open
Conversation
… to Google Search params - Auth moves from ?api_key= query param to Authorization: Bearer header (verified live against all endpoint families); client construction unchanged - Add nb_results?: number to GoogleSearchParams (accepted by the API) - Update unit tests to assert the Authorization header instead of the query param
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the API key out of the query string and into an
Authorization: Bearerheader, so keys stop showing up in URLs and server logs. Nothing changes for users — the client is constructed the same way.Also adds
nb_resultsto the Google Search params type since the API accepts it.Tested: 70 unit tests pass, and the full live suite (22 tests) passes against the real API using header auth.