Skip to content

Conversation

umihesh
Copy link

@umihesh umihesh commented Jul 17, 2025

What this PR does

This PR lazily imports the Conversation class from transformers.pipelines and handles its absence gracefully.

Why

As of transformers>=4.48.0, the Conversation class has been removed. MLServer currently imports it unconditionally, causing an ImportError at startup - even if the user is not using conversational models.

This change:

  • Moves the import inside a try-except block
  • Skips Conversation logic if the class is unavailable

This allows MLServer to work with newer versions of transformers while maintaining backward compatibility.

Related

Fixes #1955

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rlleshi
Copy link

rlleshi commented Sep 16, 2025

@RobertSamoilescu kind reminder on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import "Conversation"
4 participants