Skip to content

include security issues in exports and such #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

include security issues in exports and such #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shiftleft-utils/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@
def get_findings_counts_url(org_id, app_name, version, branch=None):
version_suffix = f"&version={version}" if version else ""
branch_suffix = f"&tags=branch={branch}" if branch else ""
return f"https://{config.SHIFTLEFT_API_HOST}/api/v4/orgs/{org_id}/apps/{app_name}/findings?per_page=249&type=oss_vuln&type=package&type=container&type=secret&type=vuln&type=extscan&include_dataflows=false&only_counts=true{version_suffix}{branch_suffix}"
return f"https://{config.SHIFTLEFT_API_HOST}/api/v4/orgs/{org_id}/apps/{app_name}/findings?per_page=249&type=oss_vuln&type=package&type=container&type=secret&type=vuln&type=extscan&type=security_issue&include_dataflows=false&only_counts=true{version_suffix}{branch_suffix}"


def get_findings_url(org_id, app_name, version, branch=None):
version_suffix = f"&version={version}" if version else ""
branch_suffix = f"&tags=branch={branch}" if branch else ""
return f"https://{config.SHIFTLEFT_API_HOST}/api/v4/orgs/{org_id}/apps/{app_name}/findings?per_page=249&type=oss_vuln&type=package&type=container&type=secret&type=vuln&type=extscan&include_dataflows=true{version_suffix}{branch_suffix}"
return f"https://{config.SHIFTLEFT_API_HOST}/api/v4/orgs/{org_id}/apps/{app_name}/findings?per_page=249&type=oss_vuln&type=package&type=container&type=secret&type=vuln&type=extscan&type=security_issue&include_dataflows=true{version_suffix}{branch_suffix}"


def get_all_apps(org_id):
Expand Down
2 changes: 1 addition & 1 deletion shiftleft-utils/convert2sarif.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ def extract_from_file(
location = {}
codeflows = []
vuln_type = vuln.get("type")
if vuln_type not in ("extscan", "vuln", "secret", "oss_vuln"):
if vuln_type not in ("extscan", "vuln", "secret", "oss_vuln", "security_issue"):
continue
details = vuln.get("details", {})
file_locations = details.get("file_locations", [])
Expand Down
2 changes: 1 addition & 1 deletion shiftleft-utils/export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def export_csv(app_list, findings, report_file):
reachability,
]
)
elif afinding.get("type") in ("vuln"):
elif afinding.get("type") in ("vuln", "security_issue"):
for loc in files_loc_list:
reportwriter.writerow(
[
Expand Down
2 changes: 1 addition & 1 deletion shiftleft-utils/stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def process_app(
vuln_counts = [
c
for c in counts
if c["finding_type"] in ["vuln", "secret", "oss_vuln", "container"]
if c["finding_type"] in ["vuln", "secret", "oss_vuln", "container", "security_issue"]
and c["key"]
in [
"severity",
Expand Down