-
Notifications
You must be signed in to change notification settings - Fork 24
Accelerated Checkouts: automate Apple Pay supported networks from merchant configuration #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fd1b784
to
abf91c6
Compare
…chant configuration
abf91c6
to
4ef0123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the PaymentSettings card brands can be used for the supportedNetworks
We can see the valid cards in my store here:
I think this is the relevant file in core, which shows the valid options
https://github.com/shop/world/blob/main/areas/core/shopify/components/payment_processing/app/services/apple_pay/payment_request_options.rb
We are missing support for cards like maestro if we use this api
@kieran-osgood-shopify Automatically obtaining credit cards from a merchant's payment settings is more on the greenpath and already supports the major credit card brands. The API can also be easily evolved to support more cards, even if it doesn't allow for all cards today. Although having the merchant configure this separately could immediately allow merchants to use all of their supported credit card brands, this pattern is not scalable for partner use cases and creates more work for merchants and potential out of sync issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved if we are happy with accepted card brands having being more limiting than the current capabilities
…chant configuration (#342) Co-authored-by: Kieran Osgood <[email protected]>
This PR automates the process of fetching the accepted card brands from the Shop configuration in the Storefront API and maps those values to Apple Pay supported networks.
In the first video every card brand is enabled:
RPReplay_Final1752744667.MP4
In the second video I've disabled Visa and, as you can see, the card is not available:
RPReplay_Final1752744185.MP4
Before you merge
Important
Checklist for releasing a new version
podspec
file.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.