Implement submitStart #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiftio
force-pushed
the
prototype-development/submit-start
branch
from
9f02a8c to
d85d943
Compare
kiftio
force-pushed
the
prototype-development/submit-start
branch
from
d85d943 to
4a422bd
Compare
kiftio
requested review from
kieran-osgood-shopify,
markmur,
michaeljsXu,
tiagocandido and
westeezy
michaeljsXu
approved these changes
Nov 28, 2025
| // MARK: - Payment Token Types | ||
|
|
||
| /// Payment token input structure for checkout submission. | ||
| public struct CartPaymentTokenInput: Codable { |
There was a problem hiding this comment.
I've renamed this to PaymentTokenInput on web, we should probably match here
Comment on lines
36
to
39
| capturedJavaScript = javaScriptString | ||
| if !javaScriptString.isEmpty { | ||
| evaluateJavaScriptExpectation?.fulfill() | ||
| } else if javaScriptString == expectedScript { |
There was a problem hiding this comment.
Is the purpose of the else if to check when they are both empty?
Contributor
Author
There was a problem hiding this comment.
yeah, this logic looks odd, tidying up
westeezy
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Implement checkout.submitStart
Before you merge
Important
Releasing a new version of the kit?
podspecfile.Releasing a new major version?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.