-
Notifications
You must be signed in to change notification settings - Fork 42
Validate Polaris Web Components for App Home Surface #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Looking great so far! I dropped a few notes as you are iterating here 😎
let result = false; | ||
let resultDetail = ""; | ||
|
||
// extract code from language-less codeblock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you haven't done so already in a local branch, we should specify in our get_started
txt response how to structure codeblocks to add more consistency here.
We'll still need to detect all codeblocks just incase LLMs forget that instruction but it will help. We do a similar pattern with GQL codeblocks with admin if you wanted to steal our homework :)
// Validate against @shopify/app-bridge-ui-types directly | ||
|
||
// Check for Shopify UI components (s-* pattern) | ||
const shopifyComponentPattern = /<s-[a-z-]+/gi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd imagine using the Typescript library instead of pattern matching here would give us better results in the short and long run. Have you explored that at all yet?
Co-authored-by: Nelson <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
🎩 Tophat Take 2Prompt
Model: claude-4-sonnetResult✅* With a single prompt, on the first try, the MCP did all of the following:
* Visual AidsDescripthttps://share.descript.com/view/J2HjRwbrsdQ LLM-generated TODOs![]()
|
@billfienberg - Will you rebase this PR from this other branch? It looks like you are a few stacked PRs behind in this PR 🙏 |
References