Version 3.9.0 - #991
Merged
Merged
Conversation
alexgomez54
approved these changes
Nov 3, 2025
alexgomez54
left a comment
alexgomez54
left a comment
There was a problem hiding this comment.
LGTM. Compared against https://github.com/Shopify/infrastructure/pull/20782, #989 and #990,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
This PR removes Elasticsearch specific logic that was introduced in 3.8.0. Elasticsearch was added to the
black_listso that it would not be marked for deletion. Based on the decision made here https://vault.shopify.io/gsd/decisions/9732, we have decided this is not the path we want to take, and want ES resources to be marked for deletion when removed from manifest files.This PR also removes the check
observedGeneration.present?before comparingobservedGenerationandgeneration. Upon further investigation, this is redundant because if it is not present, these values are set here.The version has been updated to 3.9.0 to reflect these changes and release a new version.