Drop support for no-longer-supported Rails 7.0 and clean up ✨ #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larouxn
force-pushed
the
drop_rails_7.0_support_and_clean_up
branch
from
ab510ee to
3e8bba4
Compare
adrianna-chang-shopify
approved these changes
Jul 14, 2025
larouxn
force-pushed
the
drop_rails_7.0_support_and_clean_up
branch
from
3e8bba4 to
d60ada4
Compare
|
Simply rebased on |
|
Github is stalling on the checks for |
FYI the fix is to go into the repository "Branches" settings then edit the branch protection rules for main, then scroll down, remove the statuses we don't want, and not forget to save the form. I've done it, just sharing for next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing we drop support for Rails 7.0 (not 7.1 nor 7.2, yet) as it's no longer supported as of over 3 months ago. Doing so additionally allows us to clean up quite a few
if >= 7.1type conditionals. (Rails EOL info source)