Automatically name forked processes based on callers #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
07-17-automatically_name_forked_processes_based_on_callers
branch
from
d4eff15 to
c5b4651
Compare
vinistock
force-pushed
the
07-17-automatically_name_forked_processes_based_on_callers
branch
from
c5b4651 to
c8522ad
Compare
amomchilov
approved these changes
Aug 11, 2025
amomchilov
reviewed
Aug 11, 2025
vinistock
force-pushed
the
07-17-automatically_name_forked_processes_based_on_callers
branch
from
c8522ad to
f729ba0
Compare
Morriar
reviewed
Aug 11, 2025
Morriar
reviewed
Aug 11, 2025
paracycle
reviewed
Aug 11, 2025
vinistock
force-pushed
the
07-17-automatically_name_forked_processes_based_on_callers
branch
from
f729ba0 to
cfcc46b
Compare
paracycle
reviewed
Aug 11, 2025
vinistock
force-pushed
the
07-17-automatically_name_forked_processes_based_on_callers
branch
from
cfcc46b to
d350604
Compare
|
For some reason, tests are hanging with this change. Not sure why. |
vinistock
force-pushed
the
07-17-automatically_name_forked_processes_based_on_callers
branch
3 times, most recently
from
f2b1ff9 to
e3e5fbc
Compare
vinistock
force-pushed
the
07-17-automatically_name_forked_processes_based_on_callers
branch
from
e3e5fbc to
e4ba975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From time to time, we have reports of extra child processes being created by the runtime server. It's hard to figure out where these are coming from because the user's application could be the one creating them. It could also be Tapioca or some other add-on.
This PR patches
forkto always name the forked process using the file path of the caller, so that we know where fork was called. Whilecaller_locationsis a bit expensive, I think it's worth the extra help in debugging. Please let me know if you agree.