Add support for Package URL format for source links #3807
+781
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
paracycle
added
enhancement
vinistock
reviewed
Nov 6, 2025
paracycle
force-pushed
the
uk-package-url
branch
2 times, most recently
from
4da24fb to
1c5d307
Compare
This is better than adding a gem dependency for it
paracycle
force-pushed
the
uk-package-url
branch
from
1c5d307 to
04be0c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Early on in the lifetime of this project we'd created our own source URI format to target locations inside gems. However, we'd missed the fact that a Package URL format already exists as a well adopted specification and addresses every need that we have.
Implementation
I implemented the Package URL parsing in parallel to parsing the existing Source URI comments. Once Tapioca starts generating Package URL comments, and once we feel confident that it has wide adoption, we can stop handling Source URI comments in the future.
Automated Tests
Added new expectation tests for document link with Package URL format source links.
Manual Tests