Skip to content

Allow tokenless requests #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow tokenless requests #2477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
737d5c3
Allow tokenless requests
blittle May 19, 2025
f504bb1
Add changeset
blittle May 19, 2025
8d88a16
Fix test
blittle May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fruity-comics-tease.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/storefront-api-client': minor
---

Add support for tokenless requests to the SFAPI
13 changes: 0 additions & 13 deletions ...ients/storefront-api-client/src/tests/storefront-api-client/storefront-api-client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,19 +200,6 @@ describe('Storefront API Client', () => {
)}`,
);
});

it('throws an error when neither public and private access tokens are provided', () => {
expect(() =>
createStorefrontApiClient({
...config,
publicAccessToken: undefined as any,
}),
).toThrow(
new Error(
`Storefront API Client: a public or private access token must be provided`,
),
);
});
});
});

Expand Down
8 changes: 4 additions & 4 deletions packages/api-clients/storefront-api-client/src/tests/validations/validations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import {validateRequiredAccessTokens} from '../../validations';

describe('validateRequiredAccessToken()', () => {
it('throws an error when both public and private tokens are undefined', () => {
const publicAccessToken = undefined;
const privateAccessToken = undefined;
it('throws an error when both tokens are provided', () => {
const publicAccessToken = 'publicAccessToken';
const privateAccessToken = 'privateAccessToken';

expect(() =>
validateRequiredAccessTokens(publicAccessToken, privateAccessToken),
).toThrow(
new Error(
'Storefront API Client: a public or private access token must be provided',
'Storefront API Client: only provide either a public or private access token',
),
);
});
Expand Down
6 changes: 0 additions & 6 deletions packages/api-clients/storefront-api-client/src/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@ export function validateRequiredAccessTokens(
publicAccessToken: string | undefined,
privateAccessToken: string | undefined,
) {
if (!publicAccessToken && !privateAccessToken) {
throw new Error(
`${CLIENT}: a public or private access token must be provided`,
);
}

if (publicAccessToken && privateAccessToken) {
throw new Error(
`${CLIENT}: only provide either a public or private access token`,
Expand Down