Remove context pointer #98
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcharles
force-pushed
the
jc.singleton-take2
branch
from
7052863 to
b3c98e9
Compare
adampetro
reviewed
Jun 20, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of how we could remove the context pointer from all the APIs. It simplifies the API for the consumer since they no longer need to be aware of the context, there's no pointer they need to store and pass. It also reduces fuel usage by ~6% in the tests because we do not need to perform null checks on the context.
My plan is to build on this to remove
shopify_function_context_newandshopify_function_output_finalizefrom the partner facing API and have the host environment perform the equivalent operations. Having the host perform these operations reduces the scope of what partner is responsible for (these operations should always be the same for all Functions) and will give us the option to exclude these operations from the fuel and timeout limits given these aren't really partner code and are required for a Function to be useful.