Skip to content

Remove T.unsafe from extension method call #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Remove T.unsafe from extension method call #1047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/tapioca/dsl/compilers/frozen_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ module Compilers
class FrozenRecord < Compiler
extend T::Sig

ConstantType = type_member { { fixed: T.class_of(::FrozenRecord::Base) } }
ConstantType = type_member { { fixed: T.all(T.class_of(::FrozenRecord::Base), Extensions::FrozenRecord) } }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an alternative way to explicitly tell Sorbet that T.class_of(::FrozenRecord::Base).is_a?(Extensions::FrozenRecord)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so.


sig { override.void }
def decorate
Expand Down Expand Up @@ -97,7 +97,7 @@ def self.gather_constants

sig { params(record: RBI::Scope).void }
def decorate_scopes(record)
scopes = T.unsafe(constant).__tapioca_scope_names
scopes = constant.__tapioca_scope_names
return if scopes.nil?

module_name = "GeneratedRelationMethods"
Expand Down