Compiler for GraphQL::Schema
#1733
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
Alex/GraphQL_Schema
branch
3 times, most recently
from
39a01df to
c0216ac
Compare
Which creates a strongly-typed sig for `#context`, if the context class was customized via the `context_class` DSL.
amomchilov
force-pushed
the
Alex/GraphQL_Schema
branch
from
c0216ac to
0557e1e
Compare
|
You set the context class on the Schema, but you don't actually ever read it from the Schema 🤦 I'll rework this to add sigs to the correct classes, like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which creates a strongly-typed sig for
#context, if the context class was customized via thecontext_classDSL.For Shopify employees, please see the timeline for a link to a PR with a sample application of this compiler.
Implementation
I copied the
GraphQLMutationcompiler and edited it.Tests
I copied the tests for the
GraphQLMutationcompiler and edited those, too. :)