cmd/server: remove data race between Listen and Shutdown #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shutdown is now idempotent: it does nothing if the server was never started or was already stopped. Listen is guarded by sync.Once so the HTTP server can be started at most once. Fixes Shopify#667
bmizerany
force-pushed
the
bmizerany/listenshutdownrace
branch
from
f388dff to
b9e0c9d
Compare
bmizerany
force-pushed
the
bmizerany/listenshutdownrace
branch
2 times, most recently
from
797e5e1 to
b9e0c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shutdown is now idempotent: it does nothing if the server
was never started or was already stopped.
Listen is guarded by sync.Once so the HTTP server can be
started at most once.
Fixes #667