Includes product bundle component data on line items #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgraffeocohen
force-pushed
the
alexgc/include-line-item-bundle-components
branch
from
1869603 to
daf7139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We are not passing the correct transaction data to pos.receipt-footer.block.render and other targets for product bundles. This is a critical requirement for FC Barcelona, a large merchant that needs to start becoming fiscally compliant with our partner's app. Our partner's app needs product bundle information passed to their extension target code to correctly calculate taxes for FC Barcelona and other merchants.
Solution
Adds product bundle components to the cart line item interface, which is what
TransactionCompleteDatacurrently uses. We are not including auuidfield so that the components could not be possible mutated even if queried pre checkout completion.One consideration is whether we should have a separate line item interface for transaction complete data, if we don't want to add to all cart APIs right now.
🎩
Checklist