Add Admin Modal docs and improve preview size #3281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-b-rose
changed the base branch from
unstable
to
update-admin-ui-extensions
sam-b-rose
force-pushed
the
add-admin-modal-docs
branch
from
67b8d6b to
f4585b2
Compare
sam-b-rose
force-pushed
the
update-admin-ui-extensions
branch
from
384f59e to
b24c648
Compare
sam-b-rose
force-pushed
the
add-admin-modal-docs
branch
from
f4585b2 to
d34631e
Compare
sam-b-rose
changed the base branch from
update-admin-ui-extensions
to
2025-10-rc
sam-b-rose
force-pushed
the
add-admin-modal-docs
branch
from
d34631e to
b31d58c
Compare
sam-b-rose
force-pushed
the
add-admin-modal-docs
branch
from
b31d58c to
2020923
Compare
kyledurand
reviewed
Sep 12, 2025
packages/ui-extensions/src/surfaces/admin/components/Modal/Modal.doc.ts
Outdated
Show resolved
Hide resolved
kyledurand
reviewed
Sep 12, 2025
packages/ui-extensions/src/surfaces/admin/components/Modal/examples/default.html
Outdated
Show resolved
Hide resolved
kyledurand
reviewed
Sep 12, 2025
sam-b-rose
force-pushed
the
add-admin-modal-docs
branch
2 times, most recently
from
bc11b79 to
52c6e79
Compare
kyledurand
reviewed
Sep 15, 2025
sam-b-rose
force-pushed
the
add-admin-modal-docs
branch
from
52c6e79 to
0c837c1
Compare
sam-b-rose
changed the title
kyledurand
reviewed
Sep 15, 2025
packages/ui-extensions/src/surfaces/admin/components/StandardComponents.ts
Outdated
Show resolved
Hide resolved
kyledurand
reviewed
Sep 15, 2025
| { | ||
| code: './examples/default.html', | ||
| language: 'preview', | ||
| customStyles: 'min-height: 300px;', |
There was a problem hiding this comment.
How do you pass in multiple styles here? Should this be an array?
There was a problem hiding this comment.
It is just a string. Inline styles like you'd add to a style attribute (e.g. style="color: red; background: blue;")
There was a problem hiding this comment.
I've refined this to support a CSS Style Object. Types included
sam-b-rose
force-pushed
the
add-admin-modal-docs
branch
from
0c837c1 to
36b1459
Compare
kyledurand
reviewed
Sep 16, 2025
packages/ui-extensions/src/surfaces/admin/components/Modal/Modal.ab.doc.ts
Show resolved
Hide resolved
sam-b-rose
force-pushed
the
add-admin-modal-docs
branch
from
36b1459 to
fb4afe6
Compare
kyledurand
approved these changes
Sep 16, 2025
sam-b-rose
force-pushed
the
add-admin-modal-docs
branch
from
fb4afe6 to
f5aceb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modal docs
Custom preview sizes
Screen.Recording.2025-09-15.at.4.54.02.PM.mov