Skip to content

Conversation

@JakeGBLP
Copy link
Contributor

Fixed NullPointerException in ExprYawPitch when resetting the value, improved code structure to use "newer" java features, removed redundant version check.

If unrelated commits are shown in this pr that means I did something wrong and I don't know how to fix it.

Problem

Resetting yaw or pitch causes a NullPointerException

Solution

Null check

Testing Completed

test "yaw and pitch":
	set {_test} to test-location
	assert yaw of {_test} is 0 with "The yaw of the spawn location was not 0"
	set yaw of {_test} to 90
	assert yaw of {_test} is 90 with "The yaw of the spawn location was not set to 90"
	reset yaw of {_test}
	assert yaw of {_test} is 0 with "The yaw of the spawn location was not reset to 0"

Supporting Information


Completes: none
Related: none

@JakeGBLP JakeGBLP requested a review from a team as a code owner June 22, 2025 17:53
@JakeGBLP JakeGBLP requested review from cheeezburga and erenkarakal and removed request for a team June 22, 2025 17:53
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jun 22, 2025
@sovdeeth
Copy link
Member

You made this from a branch that wasn't clean. Make a new branch based off dev/patch and make changes there

@JakeGBLP
Copy link
Contributor Author

You made this from a branch that wasn't clean. Make a new branch based off dev/patch and make changes there

Due to IRL reasons I won't be able to continue working on this, I apologize for the inconvenience and hope this goes well.

Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, just saw recent comment. Hope all is well.

@sovdeeth sovdeeth closed this Jun 30, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants