Limit literal specification regex pattern to improve matching behavior. #8068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
skriptlang-automation
bot
added
the
needs reviews
Absolutionism
approved these changes
Jul 22, 2025
APickledWalrus
approved these changes
Jul 24, 2025
Comment on lines
+717
to
+719
| if (allowUnparsedLiteral && containsObjectClass) | ||
| //noinspection unchecked | ||
| return (Expression<? extends T>) getUnparsedLiteral(log, error); |
There was a problem hiding this comment.
Hmm, does this need to be after the string literal check? My concern is that something like "%object/string%" wouldn't work right (it would always return an unparsed literal).
Maybe the string check needs to go in loop above instead?
1 task
1 task
1 task
1 task
1 task
sovdeeth
changed the title
Efnilite
approved these changes
Jul 30, 2025
skriptlang-automation
bot
added
the
patch-ready
github-project-automation
bot
moved this from In Review
to Awaiting Merge
in 2.12 Releases
skriptlang-automation
bot
removed
the
needs reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Literal specification didn't work so well in function parameters:
func(red, black (color))would fail to parse.Solution
Enforces stricter regex match rules (no {}()"' and so on in the literal, and only letters, numbers, and spaces in the codename).
Also ensures the two parseSingleExpr implementations are unified in behavior, as previously only one would attempt specified literals. Pulled duplicate code into a helper method.
Testing Completed
added to literal specification.sk
Supporting Information
Completes: none
Related: none