Skip to content

Fixes vehicle register #8092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: dev/patch
Choose a base branch
from
Open

Fixes vehicle register #8092

wants to merge 25 commits into from

Conversation

TheLimeGlass
Copy link
Contributor

Description

vehicle itself cannot be used within an on mount event.

The only change is the registerDefault and removal of Delay.isDelayed because setTime handles this. The rest is code standards.

on mount:
	broadcast "%vehicle%"
	name of vehicle is "boat"
	passengers of vehicle is set
	cancel event

Errors:
Untitled

Target Minecraft Versions: any
Requirements: none
Related Issues: none

TheLimeGlass and others added 15 commits March 11, 2024 09:23
@TheLimeGlass
Fix vehicle
07025a1
@TheLimeGlass @sovdeeth
Update src/main/java/ch/njol/skript/expressions/ExprVehicle.java
5f9001e 
Co-authored-by: sovdee <[email protected]>
@TheLimeGlass
Re-add delays
728cb8f
@TheLimeGlass
Merge branch 'fix/vehicle-register' of https://github.com/TheLimeGlas…
0873fce 
…s/Skript into fix/vehicle-register
@TheLimeGlass
Fix suggestion commit
6949abd
@Moderocky
Merge branch 'dev/patch' into fix/vehicle-register
2e00061
@TheLimeGlass
Time state changes
a99038d
@TheLimeGlass
Merge branch 'fix/vehicle-register' of https://github.com/TheLimeGlas…
d84617b 
…s/Skript into fix/vehicle-register
@TheLimeGlass
Avoid infinite mounting
a39e1b8
@TheLimeGlass
Avoid infinite mounting
e8999ec
@TheLimeGlass
Better examples
c404493
@Moderocky
Merge branch 'dev/feature' into fix/vehicle-register
9935ed1
@TheLimeGlass @Moderocky
Update src/main/java/ch/njol/skript/expressions/ExprVehicle.java
47b2a99 
Co-authored-by: Moderocky <[email protected]>
@TheLimeGlass
Use Java 17
306e3b9
@TheLimeGlass
Update to latest
b4a49ee
@TheLimeGlass TheLimeGlass requested a review from a team as a code owner July 29, 2025 21:55
@TheLimeGlass TheLimeGlass requested review from erenkarakal and Burbulinis and removed request for a team July 29, 2025 21:55
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jul 29, 2025
Absolutionism
Absolutionism requested changes Jul 29, 2025
View reviewed changes
@Absolutionism Absolutionism added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jul 29, 2025
TheLimeGlass
TheLimeGlass commented Aug 11, 2025
View reviewed changes
@Efnilite Efnilite added the 2.13 Targeting a 2.13.X version release. label Aug 11, 2025
@Absolutionism Absolutionism moved this to In Review in 2.13 Releases Aug 11, 2025
Absolutionism
Absolutionism requested changes Aug 11, 2025
View reviewed changes
TheLimeGlass
TheLimeGlass commented Aug 11, 2025
View reviewed changes
Absolutionism
Absolutionism requested changes Aug 12, 2025
View reviewed changes
sovdeeth
sovdeeth requested changes Aug 26, 2025
View reviewed changes
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Aug 26, 2025
sovdeeth
sovdeeth approved these changes Sep 23, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Absolutionism Absolutionism Absolutionism requested changes

@sovdeeth sovdeeth sovdeeth approved these changes

@erenkarakal erenkarakal Awaiting requested review from erenkarakal erenkarakal is a code owner automatically assigned from SkriptLang/core-developers

@Burbulinis Burbulinis Awaiting requested review from Burbulinis Burbulinis is a code owner automatically assigned from SkriptLang/core-developers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2.13 Targeting a 2.13.X version release. bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
2.13 Releases
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheLimeGlass @sovdeeth @Absolutionism @Efnilite @Moderocky