-
-
Notifications
You must be signed in to change notification settings - Fork 414
Global Options #8192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erenkarakal
wants to merge
13
commits into
SkriptLang:dev/feature
Choose a base branch
from
erenkarakal:feature/global-options
base: dev/feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Global Options #8192
erenkarakal
wants to merge
13
commits into
SkriptLang:dev/feature
from
erenkarakal:feature/global-options
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
requested changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The problem is explained in detail in #2028, but the general idea is that having a global options file makes it easier to change static values across lots of script files.
Solution
Added a new
options.sk
file inside/plugins/Skript/globals/
folder. The entries inside are loaded into a static map.Whenever
replaceOptions
is called, it checks if the script has that option first and returns it. If it doesn't, it gets the option from the static map instead. This lets scripts override global options.You can also use sections just like the structure version.
Testing Completed
manual testing & unit tests
Completes: #2028
Related: none