Expand the key API to allow for nested keys #8243
Open
+515
−164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are a few issues that this PR aims to address. Most notably, there is currently no straightforward way to pass entire list structures around. The other issues consist of a couple of minor bugs introduced by the previous PR.
foo(keyed {_list1::*}, keyed {_list2::*})
wherelist1
andlist2
both contain values corresponding to the same key) would throw an exception.Solution
This PR introduces new method to get an expression's values recursively, along with a corresponding
recursive
expression that makes use of that behavior. When combined with thekeyed
expression, it allows both keys and values to be returned recursively, allowing entire structures to passed around seamlessly between different contexts.Addressing the aforementioned issues:
Parameter
class that evaluates expressions with respect to the parameter's modifiers. This unfortunately makes Fix function parameters with default value as list causing error #8221 obsolete.Testing Completed
StructFunction.sk
,ExprRecursive.sk
Supporting Information
Below is a complete example showing how various combinations behave:
Using functions:
Completes: #8220
Related: none