Skip to content

Conversation

Vulcano771
Copy link
Contributor

No description provided.

@Vulcano771
Copy link
Contributor Author

Would be nice if someone could look over it

@Vulcano771
Copy link
Contributor Author

If you have better ideas how to fix this feel free to contribute

@sovdeeth
Copy link
Member

Please provide a description of the issue this fixes and how it fixes it.

@Vulcano771
Copy link
Contributor Author

Why dont you just read what I changed? Then you see what it fixes

@Vulcano771 Vulcano771 closed this by deleting the head repository Aug 10, 2025
@EquipableMC
Copy link

EquipableMC commented Aug 10, 2025

Why dont you just read what I changed? Then you see what it fixes

Because that doesn't help? They need to know exactly what is changed, why you changed it, and how it benefits everyone. Not everyone in Skript knows Java and an explanation would be a lot easier. This is also the code of conduct for making PR to SkriptLang.

@EquipableMC
Copy link

The fact you also closed it and deleted the head repository already raises concerns as well.

@Vulcano771
Copy link
Contributor Author

Because you dont seem to value it. Thats why I deleted it. If you cant read the title (fixed bug with getting the correct field or method of a class) then I cant help you.
It already says what the problem is

@Efnilite
Copy link
Member

We value your contribution, but without you explaining which bug you're exactly fixing and how you're doing it, how are we supposed to review how good your approach is?

@EquipableMC
Copy link

Because you dont seem to value it. Thats why I deleted it. If you cant read the title (fixed bug with getting the correct field or method of a class) then I cant help you. It already says what the problem is

The title doesn't explain much. What exactly is this bug? How is this broken? It doesn't need to be a full on paragraph, it can just be a few sentences on how this PR fixes it, and how it was broken before you fixed it.

@Vulcano771
Copy link
Contributor Author

PR is btw. closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants