BUG: Change Trame.json to SlicerTrame.json #2193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the extension catalog entry file from
Trame.json
toSlicerTrame.json
for consistency with the extension's advertised1 purpose and name. This avoids confusion with the broader trame project.This change also addresses the CI packaging failure reported on CDash:
By aligning the file name with the actual extension name, the build process can correctly locate the JSON descriptor, unblocking packaging.
Important
Consider reverting 86ef52b in the SlicerTrame repository for consistent naming. A force-push may be appropriate.
Related pull requests:
@Thibault-Pelletier
Footnotes
https://github.com/KitwareMedical/SlicerTrame?tab=readme-ov-file#slicertrame ↩