Skip to content

Add pausing to the serial console #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

Add pausing to the serial console #1569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
613b714
Add pausing to the serial console
gorbit99 Sep 27, 2025
c942a59
Merge branch 'main' into pause-serial-console
loucass003 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 52 additions & 4 deletions gui/src/components/settings/pages/Serial.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ import { save } from '@tauri-apps/plugin-dialog';
import { writeTextFile } from '@tauri-apps/plugin-fs';
import { error } from '@/utils/logging';
import { waitUntil } from '@/utils/a11y';
import { PauseIcon } from '@/components/commons/icon/PauseIcon';
import { PlayIcon } from '@/components/commons/icon/PlayIcon';

export interface SerialForm {
port: string;
Expand Down Expand Up @@ -64,6 +66,8 @@ export function Serial() {
setConsole('');
};

const [isPaused, setPaused] = useState(false);

const openSerial = (port: string) => {
sendRPCPacket(RpcMessage.CloseSerialRequest, new CloseSerialRequestT());
const req = new OpenSerialRequestT();
Expand Down Expand Up @@ -115,12 +119,35 @@ export function Serial() {
);

useEffect(() => {
if (consoleRef.current)
consoleRef.current.scrollTo({
top: consoleRef.current.scrollHeight,
});
if (isPaused) {
return;
}
if (!consoleRef.current) {
return;
}

consoleRef.current.scrollTo({
top: consoleRef.current.scrollHeight,
});
}, [consoleContent]);

useEffect(() => {
if (!consoleRef.current) {
return;
}

consoleRef.current.addEventListener('scroll', () => {
if (!consoleRef.current) {
return;
}
setPaused(
consoleRef.current.scrollTop +
consoleRef.current.getBoundingClientRect().height !==
consoleRef.current.scrollHeight
);
});
}, [consoleRef.current]);

useEffect(() => {
const id = setInterval(() => {
if (!isSerialOpen) {
Expand Down Expand Up @@ -206,6 +233,14 @@ export function Serial() {
}
};

const pauseScroll = () => {
setPaused(!isPaused);

consoleRef.current?.scrollTo({
top: consoleRef.current.scrollHeight,
});
};

return (
<>
<BaseModal
Expand Down Expand Up @@ -281,6 +316,19 @@ export function Serial() {
>
{l10n.getString('settings-serial-save_logs')}
</Button>
<div className="ml-auto">
<Button
variant="quaternary"
onClick={pauseScroll}
icon={
isPaused ? (
<PlayIcon width={16} />
) : (
<PauseIcon width={16} />
)
}
></Button>
</div>
<div className="w-full mobile:col-span-2">
<Dropdown
control={control}
Expand Down