DEVORTEX-5439 add webhooks api #125
Conversation
| interface SubscriptionSecretDto { | ||
| payloadSecret: string; | ||
| } | ||
|
|
||
| export { SubscriptionSecretDto }; |
There was a problem hiding this comment.
no actions points: weird naming. it's already clear this secret is in payload.
|
is this still in work (draft) or it waits for approves? |
There was a problem hiding this comment.
answering this: #125 (comment)
we are waiting for all endpoints implemented on the backend side
| interface ScrollableResponse<T> { | ||
| items: Array<T>; | ||
| hasMore: boolean; | ||
| scrollId: string | null; | ||
| } |
There was a problem hiding this comment.
Only webhooks api uses this type of pagination? I'm thinking if we should put this response interface to api/http where shared response interfaces are located.
There was a problem hiding this comment.
i was thinking about it. I can do it and put into a shared directory if you want. but this structure is very specific for Webhooks service and third-party delivery system we use. not sure that it will be helpful for other APIs. so, up to you.
There was a problem hiding this comment.
got it. let's leave as is.
| @@ -124,3 +124,4 @@ export * from "./api/mt/index"; | |||
| export * from "./api/mt/params/smartling-mt-parameters"; | |||
| export * from "./api/mt/params/source-text-item"; | |||
| export * from "./api/mt/dto/translation-text-item-dto"; | |||
| export * from "./api/webhooks"; | |||
Oh, I somehow was tricked by this: it just doesn't show number for the last line) |
No description provided.