Skip to content

feat: set requestId if not provided, log requestId on low level excep… #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: set requestId if not provided, log requestId on low level excep… #118

wants to merge 1 commit into from

Conversation

sl-pkryshtop
Copy link
Contributor

No description provided.

dimitrystd
dimitrystd approved these changes Aug 4, 2025
View reviewed changes
Copy link

@dimitrystd dimitrystd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of the fake response doesn't look good. Perhaps because of the name. But I couldn't make a better proposal.

@sl-pkryshtop
Copy link
Contributor Author

sl-pkryshtop commented Aug 4, 2025 •
edited
Loading

The idea of the fake response doesn't look good. Perhaps because of the name. But I couldn't make a better proposal.

I copied it from WebApplicationException (parent of our RestApiException), just include additional header.

@sl-pkryshtop sl-pkryshtop force-pushed the CON-1787-improve-request-id-logging branch from c70ae37 to 9e449b1 Compare August 4, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitrystd dimitrystd dimitrystd approved these changes

@AlexArcher AlexArcher AlexArcher approved these changes

@sl-mmuradov sl-mmuradov sl-mmuradov approved these changes

@vfisyuk-smartling vfisyuk-smartling vfisyuk-smartling approved these changes

@bloy-smartling bloy-smartling Awaiting requested review from bloy-smartling bloy-smartling is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sl-pkryshtop @dimitrystd @AlexArcher @sl-mmuradov @vfisyuk-smartling