Avoid complete refresh for now - #457
Open
SharonStrats wants to merge 2 commits into
Open
Conversation
…@3.1.3-17 pane-registry@3.1.2-2 solid-panes@4.4.2-7) (latest: rdflib@2.4.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now there is a problem with using the refreshUI here when the layout changes to mobile.
When in the storage view and you resize from desktop to mobile or vice versa the storage pane get rerendered and your containers collapse again. Currently the solution is to remove the call to refreshUI.
Any pane that has mobile-layout styling will not be affected it will still use that. Currently, profile-pane and folder-pane are the only pane that need structural changes when the layout changes and this is currently controlled in the pane itself.
This is something I have run across now though when implementing the new design in profile-pane and storage. I think we need something more from mashlib when it comes to the layout listening and adjusting pane layout, specifically the structure changes. I'm wondering if we also need a hook in the pane-registry that can be called for the panes so that they can rerender their mobile layout.
Also just to mention, I'm pretty sure that when we implement/finalize the new storage design the refreshUI will not be a problem since we won't have the collapsing affect anymore, the pane will take up the whole right side of the view.