Skip to content

improve logging for k8s_node_distribution_check #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
depressiveRobot wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

improve logging for k8s_node_distribution_check #1105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fa381d
improve logging
depressiveRobot Feb 18, 2026
7617c71
fix mistakes
depressiveRobot Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tests/kaas/k8s-node-distribution/k8s_node_distribution_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def compare_labels(node_list, node_type="control"):
try:
label_data[key].append(node[key])
except KeyError:
raise LabelException(f"The label for {key.split('/')[1]}s doesn't seem to be set for all nodes.")
raise LabelException(f"The label for {key.split('/')[1]}s doesn't seem to be set for all {node_type} nodes.")

for label in LABELS:
if len(set(label_data[label])) <= 1:
Expand All @@ -165,7 +165,7 @@ def compare_labels(node_list, node_type="control"):
#
# if node_type == "control":
# raise DistributionException("The distribution of nodes described in the standard couldn't be detected.")
logger.warning("No node distribution could be detected for the worker nodes. "
logger.warning(f"No node distribution could be detected for {node_type} nodes. "
"This produces only a warning, since it is just a recommendation.")


Expand Down