Bugfix: install sonobuoy executable in playbook#924
Conversation
mbuechse
force-pushed
the
fix/missing-sonobuoy-executable
branch
from
cb4e053 to
d00e8d2
Compare
playbooks/pre_cloud.yaml
Outdated
|
|
||
| - name: Install Sonobuoy | ||
| ansible.builtin.shell: | ||
| curl -L https://github.com/vmware-tanzu/sonobuoy/releases/download/v0.57.3/sonobuoy_0.57.3_linux_amd64.tar.gz | tar xz sonobuoy |
There was a problem hiding this comment.
I think it makes sense to move the URL + the Version into vars. It could also make sense to make the used arch configurable.
There was a problem hiding this comment.
something like
| curl -L https://github.com/vmware-tanzu/sonobuoy/releases/download/v0.57.3/sonobuoy_0.57.3_linux_amd64.tar.gz | tar xz sonobuoy | |
| curl -L {{ sonobuoy_tar_gz_url | quote }} | tar xz sonobuoy |
??
| do_provision: false | ||
| do_cleanup: true | ||
| sonobuoy_tar_gz_url: > | ||
| https://github.com/vmware-tanzu/sonobuoy/releases/download/v0.57.3/sonobuoy_0.57.3_linux_amd64.tar.gz |
There was a problem hiding this comment.
I do it this way:
Definition of sonobuoy_version : https://github.com/regiocloud/e2e-tests/blob/main/playbooks/gardener/pre.yml#L15 (this makes it easy to update the version with the help of e.g. Renovate).
wget and removal: https://github.com/regiocloud/e2e-tests/blob/main/playbooks/gardener/pre.yml#L58-L60
But I think it makes sense to have a sonobuoy_url like https://github.com/vmware-tanzu/sonobuoy/releases/download/v{{ sonobuoy_version }}/sonobuoy_{{ sonobuoy_version }}_linux_amd64.tar.gz here. This way it's easier to use a local mirror.
There was a problem hiding this comment.
I don't know how Renovate works. Apart from that, specifying the full url gives you the highest degree of control, and you wouldn't even notice if they change the pattern somehow.
mbuechse
force-pushed
the
fix/missing-sonobuoy-executable
branch
2 times, most recently
from
cdfb03d to
e3632ab
Compare
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
something similar was suggested by @berendt Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
mbuechse
force-pushed
the
fix/missing-sonobuoy-executable
branch
from
9df7536 to
06602ac
Compare
janiskemper
left a comment
janiskemper
left a comment
There was a problem hiding this comment.
Approving after communicating with @mbuechse that possible improvements will be part of future PRs, to see results quickly.
3 participants
Questions:
.local/binis on PATH? Otherwise, it would have to be added.Note that this method is what is officially suggested. I have found Ansible roles for installing Sonobuoy that use some obscure Debian repository, but most such roles were actually no longer available.