Skip to content

Bugfix: no leaking sensitive data; handling AttributeError #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbuechse merged 1 commit into from
May 20, 2025
Merged

Bugfix: no leaking sensitive data; handling AttributeError #926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Tests/iaas/security-groups/default-security-group-rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,17 @@ def altern_test_rules(connection: openstack.connection.Connection):
def test_rules(connection: openstack.connection.Connection):
try:
rules = list(connection.network.default_security_group_rules())
except ResourceNotFound:
except (ResourceNotFound, AttributeError) as exc:
# older versions of OpenStack don't have the endpoint and give ResourceNotFound
if isinstance(exc, ResourceNotFound) and 'default-security-group-rules' not in str(exc):
raise
# why we see the AttributeError in some environments is a mystery
if isinstance(exc, AttributeError) and 'default_security_group_rules' not in str(exc):
raise
logger.info(
"API call failed. OpenStack components might not be up to date. "
"Falling back to old-style test method. "
)
logger.debug("traceback", exc_info=True)
altern_test_rules(connection)
else:
check_default_rules(rules)
Expand Down Expand Up @@ -142,7 +147,7 @@ def main():
"--debug", action="store_true", help="Enable debug logging",
)
args = parser.parse_args()
openstack.enable_logging(debug=args.debug)
openstack.enable_logging(debug=False) # never leak sensitive data (enable this locally)
logging.basicConfig(
format="%(levelname)s: %(message)s",
level=logging.DEBUG if args.debug else logging.INFO,
Expand Down