-
Notifications
You must be signed in to change notification settings - Fork 12
Make UncommittedHistory
remember only successfully applied events
#1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yevhenii-nadtochii
wants to merge
39
commits into
master
Choose a base branch
from
fix-uncommitted-list
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 26 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
99581e8
Add missed copyright note
ad2284f
Implement `given` types for tests
2b88574
Create `package-info.java`
fb33a1b
Implement tests
32d872a
Place a temporary logging
66d246c
Prototype more tests
cfed5da
Drop redundant tests
6eadede
Refactor the test with commands in a banch
1efbae3
Extract the test into a separate test class
c3d0b0a
Prototype proof of concept
d86e192
Rollback `ServerEnvironment` and `Aggregate`
8989ddf
Comment out loggers and update the copyright year
fb6d1f9
Comment out `Delivery` set-up in `ServerEnvironment.reset()`
12d73cb
Enable `AggregateCachingTest`
4463c3b
Drop loggers
1e655f5
Add one more test
6d80980
Make `UncommittedHistory` use primitive tracking sessions
2ac008b
Drop tracking session from `UncommittedHistory`
14b900f
Drop unused declarations
b334bcf
Update javadoc
17e7973
Polish the tests
16d64ab
Document some test utilities
c9b6f16
Extract utility methods to TestEnv
b4dd9e4
Make `UncommittedHistory` decide whether it would track an event or not
a02ec44
Make `onAfterEventPlayed` accept an envelope
10440b9
Enhance documentation
aac8e4f
Rename `salary` package to `employee` and polish the code
ea35d23
Better document the suppression
f5f8d67
Fix broken imports
b189874
Use a more appropriate word in documentation
9ed5ef7
Shorten comments when one doesn't fit into a line
2e8ad44
Fix javadoc – `BoundedContext` does not close `StorageFactory`
518afae
Drop `final` method declarations out of a `final class`
0a46156
Implement `ResultedEvents` data structure
df6ca7c
Implement `AggregateResilienceTest` for cached and non-cached `Aggreg…
fc34823
Polish the code
9034c4c
Make tests assert updated entity's state
c3a0315
Rollback to the option with a transactional events applying
8461f99
Polish the code
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.