Output the details when failed to sign #1889
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Occasionally, we encounter signature failures on the CI machines. To facilitate debugging, we need to display the detailed output from signtools. @anaisbetts Could you please help review this? |
|
Hi @anaisbetts, could you help to review & approve the changes? |
|
This project is unmaintained has had no releases for over 4 years, your changes are probably not going to get merged let alone released. |
|
AFAIK this project is officially recommended within the Electron community and has a large user base. Personally, I hope it will continue to be maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.