pressing minimized button ( - ) on the editor while the editor is maximized will close the editor - #3737
Merged
Conversation
…imized will close the editor
Member
|
@jmario74 Thanks for the PR. I can confirm that the However, from my testing, the dialog does not actually close. It is minimized to the title bar, and clicking the minimized title bar restores it again. So it seems possible that this was interpreted as a close behavior, while it is actually a minimized-state inconsistency. I’m OK with merging this cleanup, but I don’t think it fully explains or resolves a real close issue. If you have exact reproduction steps for a case where the dialog is truly closed rather than minimized, please share them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the editor is minimized from a maximized state it still has the class "elfinder-maximized" which causes it to close, removing the "elfinder-maximized" class on minimize prevents it from closing.
MAXIMIZED:

MINIMIZED:
