Skip to content

pressing minimized button ( - ) on the editor while the editor is maximized will close the editor - #3737

Merged
nao-pon merged 1 commit into
Studio-42:masterfrom
jmario74:jmario74-patch-4
Apr 17, 2026
Merged

nao-pon merged 1 commit into
Studio-42:masterfrom
jmario74:jmario74-patch-4

Conversation

@jmario74

@jmario74 jmario74 commented Oct 18, 2025

Copy link
Copy Markdown
Contributor

when the editor is minimized from a maximized state it still has the class "elfinder-maximized" which causes it to close, removing the "elfinder-maximized" class on minimize prevents it from closing.

MAXIMIZED:
max

MINIMIZED:
Screenshot from 2025-10-18 12-51-54

@nao-pon

nao-pon commented Apr 17, 2026

Copy link
Copy Markdown
Member

@jmario74 Thanks for the PR.

I can confirm that the elfinder-maximized class remains on the minimized dialog clone, so removing it makes sense as a cleanup.

However, from my testing, the dialog does not actually close. It is minimized to the title bar, and clicking the minimized title bar restores it again. So it seems possible that this was interpreted as a close behavior, while it is actually a minimized-state inconsistency.

I’m OK with merging this cleanup, but I don’t think it fully explains or resolves a real close issue.

If you have exact reproduction steps for a case where the dialog is truly closed rather than minimized, please share them.

@nao-pon
nao-pon merged commit 67592ce into Studio-42:master Apr 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants