Add option to not inject gitlab tokens

[ciyer]

No description provided.

[leafty]

Why not write the logic in internal/revproxy/main.go, in RegisterHandlers() and initializeAuth()? It would be much simpler to follow and understand which middlewares are affected by the change of configuration.

When enableV1Services is false, then you can:

1. Skip initialization of:
   • coreSvcIdTokenAuth
   • dataGitlabAccessTokenAuth
   • gitlabTokenAuth
   • gitlabCliTokenAuth
   • notebooksGitlabAccessTokenAuth
2. Update how the revproxy is initialized in RegisterHandlers()

[leafty]

If I set ignoreGitlabTokens to true on a middleware that has nothing to do with GitLab, it will skip the auth entirely too, so the way the arguments are named here are an anti-pattern.

[leafty]

Misnomer: use enableV1Services: false, or use skipGitlabTokens: true

[leafty]

Probably yes. There may have been a test using this in the past.

[ciyer]

Why not write the logic in internal/revproxy/main.go, in RegisterHandlers() and initializeAuth()? It would be much simpler to follow and understand which middlewares are affected by the change of configuration.

Thanks for the review. I made the changes around wording to avoid confusion in the names and semantics of some of the variables and parameters.

I agree that putting this logic in RegisterHandlers could make it easier to understand what exactly happens when V1 services are not enabled, but I am not familiar enough with the code to carry out the implementation this way. I chose to keep the interface the same and rely on polymorphism to realize the semantics implied by the configuration, since that seemed less risky given my knowledge of the code base.

It looks like I will not be able to complete this task, and, since it overlaps with some tasks you have coming up, feel free to use the changes in this PR, or ignore them and implement it in a different way.

[leafty]

Note: superseded by #770.