fix(docker): copy synocli source into build context - #145
Open
matonb wants to merge 1 commit into
Open
Conversation
The build stage's `make` target compiles both bin/synology-csi-driver and bin/synocli, but the Dockerfile only ever COPYed main.go and pkg/ into the builder image. Any image build fails outright with "stat .../synocli: directory not found" since synocli was added (63e8c1b) without updating the Dockerfile to match.
This was referenced Jul 20, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker buildcurrently fails on an unmodified checkout ofmain. Thebuild stage's
maketarget compiles bothbin/synology-csi-driverandbin/synocli(sincebuild: bin/synology-csi-driver bin/synocliwasintroduced in the CI-workflow commit), but the Dockerfile only ever
COPYsmain.goandpkg/into the builder image -synocli/wasnever added to the
COPYlist, so the in-containermakefails:This is why it hasn't been caught by CI:
.github/workflows/ci.yamlonly runs
make builddirectly on the runner (wheresynocli/isalready present in the full checkout) and never invokes
docker build,so the two build paths diverged silently. Reproducible on a clean
checkout of
mainwith justdocker build -t test ..Fix
Add the missing
COPY synocli ./synoclialongside the existingCOPY main.go ./COPY pkg ./pkglines.Test plan
docker build -t synology-csi:test .fails on unmodifiedmainwith the error above